Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reshape constraint construction #1815

Conversation

a-zakir
Copy link
Contributor

@a-zakir a-zakir commented Dec 11, 2023

follows #1627

Copy link

watermelon-copilot-for-code-review bot commented Dec 11, 2023

Watermelon AI Summary

AI Summary deactivated by a-zakir

GitHub PRs

No results found in Jira Tickets :(

No results found in Confluence Docs :(

No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

No results found in Asana Tasks :(

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶
Why not invite more people to your team?

@@ -1,18 +1,31 @@
#pragma once
#include "ConstraintBuilder.h"

struct AreaHydroLevelData
{
std::vector<CORRESPONDANCES_DES_CONTRAINTES>& CorrespondanceCntNativesCntOptim;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::vector<CORRESPONDANCES_DES_CONTRAINTES>& CorrespondanceCntNativesCntOptim;
const std::vector<CORRESPONDANCES_DES_CONTRAINTES>& CorrespondanceCntNativesCntOptim;

Copy link
Contributor Author

@a-zakir a-zakir Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't be const see usage.

@a-zakir a-zakir changed the base branch from develop to feature/reshape-constraint-construction December 13, 2023 10:11
@a-zakir a-zakir merged commit c469974 into AntaresSimulatorTeam:feature/reshape-constraint-construction Dec 13, 2023
1 check failed
flomnes pushed a commit that referenced this pull request Dec 15, 2023
* start

* add FictitiousLoad

* shortTermStorageLevel

* flowDissociation

* bindingConstraintHour

* ghost

* this is not only about constraint builder

* pay attention to the time step

* specific issue

* bug free

* smooth green?

* M&M

* Max Pumping ok?

* Area Hydro Level (_-_)

* finally

* basic

* tiny

* clean code

* add {PMin,PMax}DispatchableGeneration

* clean code

* ConsistenceNODU ok

* NbUnitsOutageLessThanNbUnitsStop

* NbDispUnitsMinBoundSinceMinUpTime

* MinDownTime

* setup Access Control

* remove comments

* remove comments

* treat major code smells

* treat major code smells 2

* more on major code smells

* update after review

* about objects lifetime

* (does not compile) cut into small pieces

* Revert "(does not compile) cut into small pieces"

This reverts commit 5a047c0.

* aesthetic

* remove comment

* smart move

* **** move

* shallow

* customize error exception

* work on "group 1"

* fix

* update

* small

* group of constraint

* from free function to class (LinearProblemMatrixBuilder)

* update LinearProblemMatrixBuilder class

* fix

* continue to group

* implement week binding constraints group

* add HydroPowerGroup

* builder as ctor parameter

* builder as ctor parameter

* clean

* int is not a bool

* add Hydro Smoothing group

* MinMaxHydroPowerGroup

* rename

* new MaxPumpingGroup

* AreaHydroLevelGroup

* new FictitiousLoad

* New ShortTermStorageLevel

* New FlowDissociation

* NEw BindingConstraintHour

* delete copies

* New BindingConstraintDay

* about includes

* New BindingConstraintWeek

* includes...

* HydroPower

* include.......

* new HydroPowerSmoothingUsingVariationSum

* new HydroPowerSmoothingUsingVariationMaxDown

* new HydroPowerSmoothingUsingVariationMaxUP

* MinHydroPower

* MaxHydroPower

* MaxPumping

* new AreaHydroLevel

* setup FinalStockGroup

* fix

* shrink method: linear problem run

* decomposition

* remove duplicated includes

* update

* make FinalStockGroup is built

* merge conflict fix

* new P{Min, Max}DispatchableGeneration & PMinMaxDispatchableGenerationGroup

* renew StartUpCosts

* add NbUnitsOutageLessThanNbUnitsStopGroup

* minuptime

* remove copy error

* new LinearProblemMatrixStartUpCosts

* fix

* fix 2

* update CmakeLists.txt

* fix

* include errors

* fix read-write data

* add documentation

* add doc for StartUpCosts group of constraints

* remove deprecated

* work on CsrQuadraticProblem / CsrFlowDissociation

* missing include

* Update CsrFlowDissociation.h

* get rid of old code

* inline function

* CsrAreaBalance new way & rename

* fix : CsrAreaBalance = Group

* logic issue

* fix doubled NegativeUnsuppliedEnergy

* 🐍 CsrBindingConstraintHour 💥

* method call syntax

* remove old logs

* remove old code

* update QuadraticProblemMatrix

* remove copy error

* ;

* unused params

* add return type

* it's 🏃

* update

* fix

* remove old Style Constraint Builder

* ConstraintBuilder is the New ConstraintBuilder

* rename file

* rename classes

* keep renaming

* rename new_exportPaliers

* transform shared_ptr data to ref: first try

* FictitiousLoadData as ref

* shortTermStorageLevelData 💾

* FlowDissociationData

* BindingConstraintHourData

* bindingConstraintDayData

* BindingConstraintWeekData

* HydroPowerData

* Min/Max/HydroPowerData

* MaxPumpingData

* AreaHydroLevelData

* data as ctor parameter

* perf issue

* fix perf issue

* small change

* updates

* about FlowDissociationData

* optimized loop in bindingConstraintHour

* remove empty line

* continue refactor

* re-work binding Constraint Week Data

* move HydroPowerData to ctor

* set data once for {Min, Max}HydroPower

* skip windows & sonar

* same for MaxPumping

* we're ok AreaHydroLevelGroup

* ok FinalStockGroup

* fix

* update StartUpCosts Group

* fix constraint index

* changes

* CsrAreaBalance

* no shared_ptr of data anymore!

* test MinDownTime elsewhere

* test NbDispUnitsMinBoundSinceMinUpTime out of it's inner loop

* test NbUnitsOutageLessThanNbUnitsStop out of it's inner loop

* big one

* shared????

* reactivate w&s

* reshape constraint construction (#1815)

* rename method

* rename with respect to the default style

* remove default parameters

* fix

* update

* fix

* ShortTermStorageLevel specific case

* NTC fix

* .

* @guilpier-code's remark

* typo

* from PR

* move unrelated jobs from LinearProblemMatrix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants